Friday, 23 May 2014

Re: Point of reviews

On Friday, May 23, 2014 17:39:23 Didier Roche wrote:
> Le 23/05/2014 17:37, Didier Roche a écrit :
> > Le 23/05/2014 17:34, Scott Kitterman a écrit :
> >> On Friday, May 23, 2014 17:27:12 Didier Roche wrote:
> >>> Le 23/05/2014 16:35, Scott Kitterman a écrit :
> >>>> The other thing I didn't know is that CI train uploads bypass the New
> >>>> queue in Ubuntu. That made my comment irrelevant anyway. This is a
> >>>> bug
> >>>> that REALLY needs fixing. Since CI train packages are mostly Ubuntu
> >>>> specific (Qt5 is somewhat unique in this regard), I'd suggest those
> >>>> need
> >>>> review in New much more than the 75% of our packages we get from
> >>>> Debian
> >>>> unmodified that have already been through New there.
> >>>
> >>> This is the case since we had daily release and it's a bug/feature in
> >>> Launchpad itself.
> >>>
> >>> This has been discussed multiple times at UDS and vUDS. It's exactly
> >>> the
> >>> reason why that every packaging changes are halting publication (in
> >>> daily release previously, and now, in CI Train) and someone with the
> >>> proper rights (uploads rights or archive admins, depending on the
> >>> process) are reviewing the packaging diff before pushing the
> >>> publication
> >>> button.
> >>
> >> Did an archive admin review the upload that kicked off this
> >> discussion before
> >> it was released to the archive?
> >
> > I guess Robru did that as part of the process (as he seems to be the
> > one publishing it), Robert?
>
> My mistake, actually, checking the logs, it was Timo publishing it.

This is the fundamental problem. For normal uploads this kind of review is
enforced. For CI train, it's a matter of someone remembering.

Scott K

--
ubuntu-devel mailing list
[email protected]
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel